Skip to content

fix: Add support for new data hash exclusions when update manifests are pr… #1478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 7, 2025
Merged

fix: Add support for new data hash exclusions when update manifests are pr… #1478

merged 2 commits into from
Oct 7, 2025

Conversation

mauricefisher64
Copy link
Collaborator

…esent.

Changes in this pull request

When validating an update manifest the new length must be accounted for in any exclusions that appear after C2PA exclusion.

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

@mauricefisher64 mauricefisher64 linked an issue Oct 6, 2025 that may be closed by this pull request
Add support for new data hash exclusions when update manifests are present #1479
Closed
@codecov Codecov
Copy link

codecov bot commented Oct 6, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.41%. Comparing base (4e9c3f2) to head (f4b6e92).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
sdk/src/claim.rs 84.61% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1478   +/-   ##
=======================================
  Coverage   78.41%   78.41%           
=======================================
  Files         162      162           
  Lines       39518    39531   +13     
=======================================
+ Hits        30988    31000   +12     
- Misses       8530     8531    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Oct 6, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #1478 will not alter performance

Comparing fix/update_manifest_exclusions (f4b6e92) with main (8bc2a1d)1

Summary

✅ 16 untouched
⏩ 2 skipped2

Footnotes

  1. No successful run was found on main (4e9c3f2) during the generation of this report, so 8bc2a1d was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

  2. 2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@mauricefisher64 mauricefisher64 merged commit f141a6b into main Oct 7, 2025
25 checks passed
@mauricefisher64 mauricefisher64 deleted the fix/update_manifest_exclusions branch October 7, 2025 15:59
@scouten-adobe scouten-adobe mentioned this pull request Oct 6, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ok-nick ok-nick ok-nick approved these changes

@tmathern tmathern tmathern approved these changes

@gpeacock gpeacock Awaiting requested review from gpeacock

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for new data hash exclusions when update manifests are present

3 participants

@mauricefisher64 @ok-nick @tmathern